Add transformers package
#1674
Closed
Add transformers package
#1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transfomers is used for tokenization of strings. While we do currently import `titoken` as well, we want to use `transformers` to count tokens the same way Seer does in Sentry for stacktrace token counts. We could consider converting usages of `titoken` to `transformers` to maintain a dependency on only one tokenization package, but for now we will have them both.
JoshFerge
requested changes
Sep 29, 2025
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
for many reasons we've decided not to add numpy and friends to the main sentry monorepo, if we want to re-evaluate this we should consider broader architecture changes (the whole reason seer exists is because we couldn't put numpy in the sentry monorepo)
Member
Author
|
@JoshFerge I see, thanks for the context, funny I had no idea that was the motivation for it - closing this, I am going to convert to importing only the tokenizers part as suggested by @kddubey in another PR. It does not depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfomers is used for tokenization of strings. While we do currently import
titokenas well, we want to usetransformersto count tokens the same way Seer does in Sentry for stacktrace token counts.We could consider converting usages of
titokentotransformersto maintain a dependency on only onetokenization package, but for now we will have them both.